Reset errors before reloading dmypy suggestion targets - #21810
Open
daleselaji-dev wants to merge 1 commit into
Open
Reset errors before reloading dmypy suggestion targets#21810daleselaji-dev wants to merge 1 commit into
daleselaji-dev wants to merge 1 commit into
Conversation
daleselaji-dev
marked this pull request as ready for review
August 5, 2026 03:23
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dmypy suggest --callsites.The suggestion engine temporarily rechecks modules and flushes their messages. Reloading the module without resetting
Errorsleft the flushed-file bookkeeping populated, so the next check could assert inErrors._add_error_info. This fixes #21765.Tests
py -3.10 -m pytest -q mypy/test/testdaemon.pypy -3.10 -m ruff check mypy/suggestions.pygit diff --checkThis change was prepared with Codex assistance and reviewed and verified by the submitting contributor.