gh-156466: fix cleanup on error in codegen_leave_annotations_scope - #156497
Merged
Conversation
iritkatriel
added
needs backport to 3.14
JelleZijlstra
approved these changes
Aug 28, 2026
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
This was referenced Aug 28, 2026
iritkatriel
removed
needs backport to 3.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codegen_leave_annotations_scopecould return on an error before the call to_PyCompile_ExitScope, and then the scope would not exit. Moved the_PyCompile_ExitScopeup.Also renamed the function because otherwise a return value of
Falseshould mean "I did not exit the scope". Now the name is not about leaving the scope (we always leave the scope).