gh-155143: Fix asyncio.shield leaking tasks via await-graph. - #155144
Open
pteromys wants to merge 2 commits into
Open
gh-155143: Fix asyncio.shield leaking tasks via await-graph.#155144pteromys wants to merge 2 commits into
pteromys wants to merge 2 commits into
Conversation
There were two places where `cur_task` could live until `inner` ended: 1. `inner._asyncio_awaited_by`, and 2. as a capture in `_clear_awaited_by_callback` in `inner._callbacks`.
pteromys
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 4, 2026 02:52
| test_utils.run_briefly(self.loop) | ||
| self.assertTrue(outer.cancelled()) | ||
| self.assertEqual(0, 0 if outer._callbacks is None else len(outer._callbacks)) | ||
| self.assertEqual(0, 0 if inner._asyncio_awaited_by is None else len(inner._asyncio_awaited_by)) |
Contributor
There was a problem hiding this comment.
Suggested change
| self.assertEqual(0, 0 if inner._asyncio_awaited_by is None else len(inner._asyncio_awaited_by)) | |
| self.assertFalse(inner._asyncio_awaited_by) |
Contributor
Author
There was a problem hiding this comment.
Applied, thanks! Should we also apply the same simplification to the preceding line about outer._callbacks, or just leave it as-is since we wouldn't otherwise be changing it?
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #155143