fix: correct the recursion available header flag to the rfc 1035 value - #1893
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Merging this PR will improve performance by 8.19%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_sending_packets |
112.7 µs | 104.1 µs | +8.19% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix_ra_flag (e1377d1) with master (d5f4102)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1893 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3911 3911
Branches 568 568
=======================================
Hits 3906 3906
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
_FLAGS_RAhas been0x8000since 2009, which is the QR bit. RFC 1035 section 4.1.1 puts Recursion Available at bit 7,0x0080.Details
Test plan