Skip to content

Revert "fix(build): set CARGO_TARGET_DIR per package" - #1303

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:revert-cargo-target-dir
Aug 11, 2026
Merged

Revert "fix(build): set CARGO_TARGET_DIR per package"#1303
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:revert-cargo-target-dir

Conversation

@tiran

@tiran tiran commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit 00344bb and PR #1301.

The CARGO_TARGET_DIR setting is not needed. The Rust compiler uses a local directory in the current workspace (project) by default. The downstream issue was caused by a configuration setting in downstream.

See https://doc.rust-lang.org/cargo/reference/build-cache.html

…lel build collisions"

This reverts commit 00344bb.

The `CARGO_TARGET_DIR` setting is not needed. The Rust compiler uses a
local directory in the current workspace (project) by default. The
downstream issue was caused by a configuration setting in downstream.

See https://doc.rust-lang.org/cargo/reference/build-cache.html

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
tiran requested a review from a team as a code owner August 11, 2026 06:00
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The change removes the public has_rust_build_backend helper and its Rust backend detection logic. It also removes the unused Rust vendor import and automatic CARGO_TARGET_DIR handling from wheel builds. The previous Rust backend detection tests are deleted. Wheel tests now cover default Cargo target assignment, explicit target preservation, and non-Rust package handling.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states that the pull request reverts the change that set CARGO_TARGET_DIR per package.
Description check ✅ Passed The description explains the CARGO_TARGET_DIR reversion and its cause, which directly matches the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Aug 11, 2026
@mergify
mergify Bot merged commit 244af54 into python-wheel-build:main Aug 11, 2026
39 checks passed
@mergify

mergify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants