Repository navigation
Support handing off coroutines between Trio and other runners - #732
Merged
Merged
Conversation
I'm not sure if this is a good idea, but I guess we'll give it a try and see how it goes. Closes python-triogh-649.
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 99.31% 99.32% +<.01%
==========================================
Files 96 96
Lines 11464 11562 +98
Branches 820 824 +4
==========================================
+ Hits 11386 11484 +98
Misses 58 58
Partials 20 20
Continue to review full report at Codecov.
|
oremanj
approved these changes
Oct 15, 2018
oremanj
left a comment
oremanj
left a comment
Member
There was a problem hiding this comment.
Clever! I appreciate that this can be done with such a minimal change to the run loop.
Member
Author
|
Guess I'll go ahead and merge this then. The real test will be to see how well it works in trio-asyncio... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea, but I guess we'll give it a try
and see how it goes.
Closes gh-649.