Skip to content

Extend 102 to excepts, 104 also catch yield - #18

Merged
Zac-HD merged 3 commits into
python-trio:mainfrom
jakkdl:8_expand_trio102
Aug 2, 2022
Merged

Zac-HD merged 3 commits into
python-trio:mainfrom
jakkdl:8_expand_trio102

Conversation

@jakkdl

@jakkdl jakkdl commented Aug 2, 2022

Copy link
Copy Markdown
Member

Also add info to error messages on 102&103, rename variables and minor refactor of Visitor102 to match later visitors.

…es on 102&103, rename variables and minor refactor.
Comment thread flake8_trio.py Resolved
Comment thread flake8_trio.py Resolved
Comment thread flake8_trio.py Resolved
Comment thread flake8_trio.py Resolved

@Zac-HD Zac-HD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions below and one above; once those are handled it's ready to merge 🎉

Comment thread tests/test_flake8_trio.py Resolved
Comment thread tests/trio102.py Resolved
@Zac-HD
Zac-HD merged commit 23e2d89 into python-trio:main Aug 2, 2022
@Zac-HD Zac-HD mentioned this pull request Aug 5, 2022
12 tasks done
@jakkdl
jakkdl deleted the 8_expand_trio102 branch August 23, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants