Repository navigation
Add TRIO222, extend TRIO221, flake8-async redundant - #119
Merged
Merged
Conversation
… os.spawn[...], flake8-async now fully redundant.
Zac-HD
force-pushed
the
flake8_async_os_functions
branch
from
February 2, 2023 00:09
7dcdea6 to
b40c6fd
Compare
Zac-HD
force-pushed
the
flake8_async_os_functions
branch
from
February 2, 2023 00:12
b40c6fd to
f858956
Compare
Zac-HD
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since https://docs.python.org/3/library/os.html#os.posix_spawn recommends using
subprocess.runinstead I assumed it should use the same error message as it.Feels kinda hard to give a good drop-in replacement for
os.wait*since it may be used for so much, but made a guess - feel free to suggest something else.Closes #58 at last! And also makes flake8-async fully redundant