Repository navigation
add TRIO212: sync call on httpx.Client, move type-tracking logic - #118
Merged
Merged
Conversation
jakkdl
changed the title
10 of 12 tasks
jakkdl
force-pushed
the
trio212_httpx_client
branch
from
January 31, 2023 13:43
270017b to
9433051
Compare
Member
Author
|
CI found a typo in |
jakkdl
force-pushed
the
trio212_httpx_client
branch
from
January 31, 2023 14:05
9433051 to
7d78fa7
Compare
Member
Author
|
Also added urllib3 pools. Didn't add explicit blocking methods on those since they're so many, but presumably there might be some. (Though probably easier to add a whitelist of allowed method calls). |
Member
|
Nice! I'll aim to release in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticks another box in #58
All the code ... just worked .. on the first try?? I got so paranoid about the testing infrastructure being broken, but nope - turns out I was just writing correct code over and over.
Not the prettiest class structure since the type-tracking class can't be reused for classes that don't want to inherit from Visitor200, but I'll fix that if/when I want to do that. Or does nurseries want this functionality? Or anything else?
The diff looks relatively large because a big chunk of code is moved without being modified, but this should otherwise be pretty straightforward to review.