[jakkdl]

Kind of a massive overhaul, and somewhat WIP with some file names and structure being stuff I plan to improve on. But this should make working with the files, seeing diffs, interdependence between visitors/tests/files, and all that jazz be easier.

It's rebased on top of #102.

[jakkdl]

oops, looks like I broke installation again. Will look at it later today

[jakkdl]

Yay, about time I started figuring out how python packaging works.
Reasonably happy with this structure.

[jakkdl]

Ran the code with flake8-type-checking to move some more imports into TYPE_CHECKING blocks since I'd already mostly done that anyway. It also wanted casts to be with string literals, but I ignored that.

Started going through the code to write a review summarizing changes, but since there's barely any code changes it was more like writing file docstrings ... so I just did that instead and enabled flake8-docstrings (but with most docstring requirements ignored). Will do a quick review of the code that's actually meaningful to look at, but otherwise it's just the file structure/organization that's up for review - don't bother looking for differences in the contained code unless I've marked it.

also: note that this is rebased on top of #102, so you can either merge that before looking at this, or just look at the second commit.

[jakkdl]

Rebased on top of main, and modified flake8_trio/__init__.py/from_filename to be excruciatingly correct 👌

[Zac-HD]

OK, took me a while to read (and I imagine you a while to write!), but it all looks good to me.

Comments below can be addressed in a follow-up PR rather than this one, to minimize the review/merge-conflict/general overhead burden. And thanks again!

[jakkdl]

No wonder it took you a while to read through it if you took it as an opportunity to re-read the whole codebase! Writing the PR did take me a bit, but that was "just" about moving files, juggling imports and fixing installation - I neither touched nor read the vast majority of the code I was shuffling around.

Will get a PR with various small fixes right away 👍

[Zac-HD]

Haha, yeah, I trusted that was the case but GitHub doesn't have a good moved-code view so I just read the lot 😅