trio200-blocking-calls = is loaded but not parsed from a config file #84

Activity

1. Zac-HD

   added

   bugSomething isn't workingSomething isn't working

   on Dec 17, 2022
2. Zac-HD

   assigned

   jakkdl

   on Dec 17, 2022
3. jakkdl commented on Dec 18, 2022

   

   jakkdl

   on Dec 18, 2022

   Last edited by jakkdl

   Member

   More actions

   I think the actual problem here is flake8's comma_separated_list .. apparently treating spaces as commas?

   flake8 --no-checkpoint-warning-decorators="a b, c d" <file>

   ipdb> self.options.no_checkpoint_warning_decorators
   ['a', 'b', 'c', 'd']

   EDIT: No, I think that's a separate problem? Maybe.
4. jakkdl commented on Dec 18, 2022

   

   jakkdl

   on Dec 18, 2022

   Member

   More actions

   New try: It looks like the action parameter to flake8.options.manager.OptionManager.add_option() is entirely ignored when parsing a config file. The supplied function is never called, and it's the same thing with ListOfIdentifiers for --startable-in-context-manager, invalid identifiers aren't flagged. Instead the values are just accepted straight up.
   Passing the same values at the command line works as expected.

   Will delve more into flake8's internals to figure out what's going on, and probs open an issue over there. I'm opening a PR with a dirty workaround, travelling to family for holidays in the coming days so a more thorough exploration might be delayed.

   (and then also fix spaces)
5. jakkdl commented on Dec 19, 2022

   

   jakkdl

   on Dec 19, 2022

   Member

   More actions

   Opened PyCQA/flake8#1770 and PyCQA/flake8#1771
6. Zac-HD commented on Dec 19, 2022

   

   Zac-HD

   on Dec 19, 2022

   MemberAuthor

   More actions

   Apparently we should just avoid action entirely and use type instead PyCQA/flake8#1770 (comment) 🤷
7. jakkdl

   added 2 commits that reference this issue on Dec 29, 2022

   fix python-trio#84 and python-trio#89, --startable-in-context-manager…

   ...

   This issue will close once commit e037c92 is merged into the 'main' branch.

   e037c92

   fix python-trio#84 and python-trio#89, --startable-in-context-manager…

   ...

   This issue will close once commit 8cc9e52 is merged into the 'main' branch.

   8cc9e52
8. Zac-HD

   closed this as completedin #93on Dec 31, 2022
9. Zac-HD

   added a commit that references this issue on Dec 31, 2022

   Merge pull request #93 from jakkdl/config_parsing_type

   ...

   115eb5e