Extra (unnecessary) 3.12 test run in CI #422

Activity

1. jakkdl commented on Dec 15, 2025

   

   jakkdl

   on Dec 15, 2025

   Member

   More actions

   as the comments say:
   

   flake8-async/.github/workflows/ci.yml

   Lines 44 to 47 in 61ee52b

   	- name: Run tests with flake8
   	run: python -m tox -e flake8
   	- name: Run tests without flake8
   	run: python -m tox -e "" -- --no-cov

   it's to run once with flake8 installed, and once without. If we wanted to shorten CI times we could move that into the matrix though. It's also possible it's somewhat overkill to test both with&without flake8 on all python versions, but given the pace of this project as of late I don't think that's worth changing.
2. jakkdl

   closed this as completedon Dec 15, 2025
3. A5rocks commented on Dec 15, 2025

   

   A5rocks

   on Dec 15, 2025

   ContributorAuthor

   More actions

   Ah, I meant the "Run tests without flake8" was running 2 pytest runs, one for the Python installed earlier and one for the system Python (?).

   But point taken about not being worth the effort.
4. jakkdl

   reopened this on Dec 16, 2025
5. jakkdl commented on Dec 16, 2025

   

   jakkdl

   on Dec 16, 2025

   Member

   More actions

   oh, I'm sorry for not checking the log. That is a bit strange, it appears that python -m tox -e "" -- --no-cov attempts to run all python versions. Not sure if there's been a config change on our side, change in how tox interprets it, or it's always been misconfigured.

   ❤️React with ❤️1Reacted by A5rocks
6. Zac-HD

   closed this as completedin 963d4dfon Apr 21, 2026
7. Zac-HD

   added a commit that references this issue on Apr 22, 2026

   Various small fixes (python-trio#445)

   ...

   This issue will close once commit 963d4df is merged into the 'main' branch.

   963d4df