* Fix CI running extra tox envs, and ASYNC300 on return In tox 4, `tox -e ""` is treated as "no env specified" and falls back to the default envlist, so the "Run tests without flake8" step was running every `py3xx-flake8` env whose interpreter tox could discover on the runner (including the system Python 3.12), instead of a single no-flake8 test run. Replace the trailing-comma empty env with a proper `[testenv:no_flake8]` section and point CI at it. Also allow `return asyncio.create_task(...)`: treat `Return` like `Assign` in Visitor300, since the caller preserves the task. Fixes python-trio#422 Fixes python-trio#398 * Address issue python-trio#310 points 1 and 4 1. Document using ruff's `lint.external` setting so that `# noqa: ASYNC...` comments survive when both ruff and flake8-async are in use. 4. Apply the `self.novisit = True` fix proposed in python-trio#307 at the end of `Visitor102.visit_Try`. The previous code happened to work because the internal `visit_nodes` calls left `self.novisit` True on exit, but relying on that is fragile; making it explicit matches the pattern used elsewhere and documents the intent. * Run compile() against tests/eval_files to catch syntax mistakes ast.parse() accepts some code the bytecode compiler rejects (e.g. `x = lambda: await foo()`, `return` outside a function), so a bad test fixture could silently slip past the plugin's ast-based checks. Add a new parametrized test that runs compile() on every tests/eval_files/*.py. A handful of existing fixtures intentionally contain such constructs to exercise edge cases; mark those with a new `# NOCOMPILE` magic marker so the new test skips them while still leaving the rest of the suite guarding against accidents. Fixes python-trio#268 * Drop docs/test-only entries from changelog Docs and test changes aren't user-visible, so they don't need a changelog entry. The ASYNC300 behaviour change stays. * Mark async911.py as # NOCOMPILE for Python 3.10 Python 3.10's compile() rejects nested async comprehensions inside an async function with "asynchronous comprehension outside of an asynchronous function"; 3.11 became permissive here. The file parses fine with ast.parse on every supported version, which is all the plugin needs, so tag it with the existing # NOCOMPILE marker (also in the matching autofix fixture to keep the diff clean). --------- Co-authored-by: Claude <noreply@anthropic.com>

run compile() on eval_files #268

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions