Repository navigation
Add hostname and timestamp to JUnit XML testsuite tag - #5692
Merged
Merged
Conversation
nicoddemus
requested changes
Aug 3, 2019
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks!
Great patch!
The change conforms to xunit2. 👍
Some changes though:
os.unameis not available on Windows. I believeplatformcan provide a suitable alternative.- Please target
features, as this is a new feature and not a bug-fix.
Also it would be great if we could merge this after #5605, but that depends on us.
Thanks again!
Codecov Report
@@ Coverage Diff @@
## features #5692 +/- ##
============================================
+ Coverage 94.53% 94.82% +0.28%
============================================
Files 117 117
Lines 25827 25843 +16
Branches 2495 2495
============================================
+ Hits 24416 24505 +89
+ Misses 1072 1017 -55
+ Partials 339 321 -18
Continue to review full report at Codecov.
|
Contributor
Author
|
@nicoddemus I've made the changes - I had forgotten about |
nicoddemus
approved these changes
Aug 5, 2019
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Dec 10, 2019
Add hostname and timestamp to JUnit XML testsuite tag Conflicts: testing/test_junitxml.py
nicoddemus
added a commit
that referenced
this pull request
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch for bug fixes, documentation updates and trivial changes.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order;