Repository navigation
WIP Update nodes.py for supporting unicode nodeid - #4567
liuchunming033 wants to merge 1 commit into
Conversation
support unicode
|
hi @liuchunming033 , i presume you are trying to make pytest ready for use with your native language, which is a great goal 👍 as the failed test shows, there are probably a few more unfortunate assumptions in the codebase about unicode names and unicode test names, in particular with the way that bytes are encoded in test names as well so i fear there is going to be quite a chunk of unexpected work and extra test writing needed to make the handling of this solid while we do have some good results with unicode in parameters, so i'm thrilled to see someone affected with those details taking a closer look as at least i am pretty ascii centric and cant even hope to do this due diligence as of now |
|
I would hold this until we drop Python 2 support, because while it is possible, there are too many gotchas in Python 2 to support this sanely. |
|
Goals achieved which I use my native language describe my test case name. |
|
Hi @liuchunming033, It has been a long time since it has last seen activity, plus we have made sweeping changes on master to drop Python 2.7 and 3.4 support, so this PR has some conflicts which require attention. You might give this another go now that In order to clear up our queue and let us focus on the active PRs, I'm closing this PR for now. Please don't consider this a rejection of your PR, we just want to get this out of sight until you have the time to tackle this again. If you get around to work on this in the future, please don't hesitate in re-opening this! Thanks for your work, the team definitely appreciates it! |
support unicode
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;