Repository navigation
Add an internal "register fixture" API and use it replace object patching for fixture injection - #11780
Merged
Conversation
nicoddemus
approved these changes
Jan 6, 2024
nicoddemus
left a comment
nicoddemus
left a comment
Member
There was a problem hiding this comment.
As is this is already a great improvement, awesome work!
I think we should merge this, and discuss later how/if expose this as part of the public API.
bluetech
force-pushed
the
register-fixture
branch
from
January 6, 2024 13:42
47a38c2 to
4c71361
Compare
Add a function on the `FixtureManager` to register a fixture with pytest. Currently this can only be done through `parsefactories`. My aim is to eventually make something like this available to plugins, as it's a pretty common need.
…egister_fixture` Instead of modifying user objects like modules and classes that we really shouldn't be touching, use the new `_register_fixture` internal API to do it directly.
bluetech
force-pushed
the
register-fixture
branch
from
January 8, 2024 19:03
4c71361 to
c8792bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Based on #11776, ignore first commit)
See the commit messages, and the discussion in #11662.