Repository navigation
basetemp should not be collected #7947
Description
when using a basetemp in the test collection source directory and adding valid, failing pytests to it the tests are collected before the basetemp directory is ensure_reset_dir'd
related to #7940
def test_basetemp_not_collected(testdir):
testdir.makepyfile(
r"""
def test(tmp_path):
(tmp_path / "test_fail.py").write_text(
"def test_fail():\n assert False"
)
"""
)
assert testdir.runpytest("--basetemp=tmp").ret == 0
# running a second time and ensure we don't crash
assert testdir.runpytest("--basetemp=tmp").ret == 0
Activity
graingert commentedon Oct 26, 2020
@RonnyPfannschmidt should collect call
TempPathFactory.getbasetemp(and rm_rf the tmp dir) or should it be excluded by default?graingert commentedon Oct 26, 2020
secondly, what should happen if the basetemp is different between runs? Should pytest clean basetemp after the run?
should pytest add a
.pytest-basetempsentinel file for collect to ignore?RonnyPfannschmidt commentedon Oct 27, 2020
I'd leave ignoring basetmp to the user