fix(server): reject unsupported rollback before admission - #850
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…rted-admission-20260924 # Conflicts: # apps/server/src/orchestration/Layers/CheckpointReactor.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh
thread.checkpoint.revertandthread.conversation.revertrequests previously received an accepted dispatch receipt when the provider exposed only relative or unsupported conversation rollback. The request event was persisted without a durable rollback operation, and the reactor reported failure later. Both commands now fail with a typed admission error before any revert-request event or saga is persisted when absolute rollback cannot be proved or the admission service is absent.The production server wires the real admission layer. Existing accepted command receipts and matching active rollback sagas remain idempotent handoffs. Tests for historical persisted revert events now replay the exact stored event through a ready reactor subscription, preserving coverage of old-event recovery without pretending a new request was accepted.
Validation after reconciliation with current
pylon: 74 focused tests passed, one skipped; server typecheck, changed-file lint/format, and diff check passed. The earlier source review passed, and the conflict resolution was reviewed against the current admission and idempotency paths. No live provider rollback was performed.Related: #200. This closes the admission-receipt gap only; #200 has separate workspace ownership and mobile status requirements.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.