fix(server): preserve manual thread titles during generation - #843
Merged
Merged
Conversation
…e/viewed-files-worker-20260924
…ead-title-intent-20260924 # Conflicts: # apps/server/src/persistence/Migrations.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deployment failed for project pylon-marketing with the following error: Learn More: https://vercel.com/pylon-code?upgradeToPro=build-rate-limit |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…a' into reconcile/pr815-20260925
…les' into reconcile/pr843-20260925
…com/pylon-code/pylon into feat/thread-title-intent-20260924
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delayed first-turn title or provider metadata update can overwrite a manual rename, including when the user renames a thread back to the same text. Persist a command-versioned title intent and accept automatic title completions only while the expected title and version still match. Archive/reopen, deletion, a newer title, and explicit regeneration invalidate stale completions. Imported history remains conservative; older event payloads still decode.
This is a partial adaptation of upstream
7cafe52bb8f1a4f26e9a8504c53ceae5cb32548a. It keeps Pylon's existing title-generation call count. The upstream automatic post-turn refinement would add another model call and remains a separate product/cost decision; provider-link refactors08abda9dcf6fee89561f861004efb48bad665df2anda62e7d670c67bf221a5699b5a988367781fead74are outside this fix.Depends on #815 at refreshed head
360f814b9161e6af0a9e4ed64e80f445755f52b2, merged into this branch. Merged Relay recovery owns migration 063, #815 owns migration 064, and this PR adds migration 065. For focused title-only review, compare the #815 prerequisite head with this PR head.Validation: 169 focused contract/server tests, 153 ingestion/snapshot/decider tests, and final 15 targeted title tests passed; contracts, client-runtime, and server typechecks passed. Pinned Effect diagnostics checked 1035 server files with zero diagnostics. Scoped lint/format and diff checks passed. Independent read-only review passed. No live provider or browser session was exercised.
The independently useful part of upstream
a62e7d670c67bf221a5699b5a988367781fead74is adapted here: title-generation and recovery warnings now log only a failure category and reason count, rather than a formatted cause that can include provider CLI output. Its provider link-decoding changes still depend on the separate08abda9dlookup feature.Refreshed head
82795d32bcdabcfe7a1d999826f16f31171d07e3: merged the updated #815 prerequisite and currentpyloncleanly. Eight focused test files passed (352 tests); server, contracts, and client-runtime typechecks, scoped lint, diff check, and frozen offline install passed. Final-head CI is pending.CI follow-up: the merged #815 prerequisite exposed three repository-wide lint errors in existing reactor tests; this branch changes those four dispatch calls to the harness-owned Effect runtime. Focused approval/user-input tests, scoped lint and format passed.