fix(preview): preserve picking and align animated surfaces - #839
Merged
Merged
Conversation
…(#9741) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> (cherry picked from commit 1ab2dfb5a7bd2996f79407b5d02cae6132a7626c)
(cherry picked from commit 4cc984fedc33184c0a0fb67ea17fb02902ae2224)
Keep element picking armed across subframe navigation, observe inline preview panel movement, and use the shared resize lifecycle for the sidebar rail.
|
Deployment failed for project pylon-marketing with the following error: Learn More: https://vercel.com/pylon-code?upgradeToPro=build-rate-limit |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element picking could stop after an iframe navigated because its one-shot navigation listener was consumed before the main frame changed. Picking now stays armed through subframe navigation and cancels on main-frame navigation, with the listener removed at session cleanup.
Inline preview panels can animate their outer width while the browser slot keeps its own size; the slot now observes the panel too, so its leased surface tracks movement. The sidebar rail uses Pylon's existing shared resize lifecycle, preserving its accepted-width rule and saved width while committing the final pointer position and cleaning up interrupted drags. This selectively adapts upstream
1ab2dfb5,4cc984fe, and the SidebarRail portion of46140c96; Pylon already had the shared resize hook.Verification: 114 focused tests, web and desktop typechecks, scoped lint and formatting. Independent source/test review passed. Live Electron/browser motion was not exercised because this task has no browser/computer-use approval.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.