fix(devices): skip local SSH hosts and check selected environments - #766
Merged
Merged
Conversation
…698) (cherry picked from commit 1ced38a6647b7f466b535b4b413ca4a74303da8e)
Adapt upstream 8984f8103d0836c0b340fe70cd053428d622a8c3 to Pylon's selected-environment host ownership and retry UI.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH device hosts that resolve to the environment server's own machine currently try to connect back over SSH, while adding a host checks only the primary environment even when several environments are selected. A local target now resolves to the existing local device host; forwarded ports, proxies, remote addresses, and unresolved targets remain SSH hosts. Adding or editing a host checks every selected environment independently, with results tied to the target and environment set. Saving still updates the environment shown in Pylon's Devices section.
This adapts upstream
1ced38a6647b7f466b535b4b413ca4a74303da8eand8984f8103d0836c0b340fe70cd053428d622a8c3while preserving Pylon's provider settings mutation fence, selected-environment ownership, host Retry action, and tool status. The web source is a Pylon adaptation rather than a wholesale component copy.Validation: 7 focused server/web tests,
t3and web typechecks, scoped lint and formatting, and clean diff checks passed. Server tests cover local, remote, forwarded, proxied, and unresolved destinations; web tests cover independent environment outcomes, input normalization, and stale-result fencing. Browser before/after images were not captured because browser use requires separate authorization under AGENTS.md. No isolated live SSH test host was available, so remote end-to-end verification was not performed.Implemented by GPT-6 Sol in the Codex/Pylon harness.