Skip to content

docs(upstream): record Cycle #689 adoptions in review ledger #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 1 commit into from
Sep 20, 2026
Merged

docs(upstream): record Cycle #689 adoptions in review ledger #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .agents/upstream-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ The maintainer authorized compatible catch-up and routine adaptations that prese

## Active cycle

None currently active. Upstream integration cycle #685 is completed.
None currently active. Upstream integration cycle #689 is completed.

## Latest cycle

[Upstream integration cycle #685](https://github.com/pylon-code/pylon/issues/685) completed web chat/diff/citation polish and external editor discovery (PR #686), and server PR diff cache eviction, ACP SDK elicitation, Codex app permission approvals, and preview host recovery (PR #687) through upstream bound `c14f6015bfe479d313355cb234af1a5c16dbb15f`. Previous cycle [#682](https://github.com/pylon-code/pylon/issues/682) completed web interaction fixes (PR #683) and runtime fixes for Claude homePath, ACP stderr, and GTK4 snapshot text (PR #684).
[Upstream integration cycle #689](https://github.com/pylon-code/pylon/issues/689) completed OTLP log exports, desktop main-process telemetry, and per-signal observability settings (PR #690) through upstream bound `fa1e1715538f6f8ac076761f7821f68479f616ab`. Previous cycle [#685](https://github.com/pylon-code/pylon/issues/685) completed web chat/diff/citation polish and external editor discovery (PR #686), and server PR diff cache eviction, ACP SDK elicitation, Codex app permission approvals, and preview host recovery (PR #687).

Previous completed cycles: [#526](https://github.com/pylon-code/pylon/issues/526) through `d1d15c67f4a5fb82fd8d5e01e5e3b288296789c3`, [#516](https://github.com/pylon-code/pylon/issues/516) through `b1e223e2b0d87124883b1410ab52dd6a1338e40d`, [#497](https://github.com/pylon-code/pylon/issues/497) through `4a4c6dd2adc350a68ba18bb28b24b5a7e4660dab`, and [#414](https://github.com/pylon-code/pylon/issues/414) through `6c583620ff7ad3235b135af7107c0543467eecfa`. Their trigger audits and exclusions describe those cycles' closure state; current dispositions below supersede them. Follow the skill's [continuation procedure](skills/review-t3-upstream/references/continuation.md), checking the issue against Git and GitHub before acting.

Expand All @@ -35,6 +35,7 @@ Historical groups are indexed in the linked archive. This file migration changes

| Group / bounded head | Sources | Outcome and remaining scope | Pylon PR / verification |
| ----------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| OTLP log export, desktop main process telemetry, and per-signal observability / `fa1e1715538f6f8ac076761f7821f68479f616ab` | `3bb06ad910389fcfc886bd5156f41dc73f307f80` (#12493), `82059df15233fb11bb5c72e737c35804364177db` (#12520), `a8693eb4ed12a445d8b8719c8f00fc9d37537599` (#12540), `fa1e1715538f6f8ac076761f7821f68479f616ab` (#12657) | Adopted all four in Cycle #689 (PR #690). Server exports structured log records over OTLP with trace/span ID correlation, replaces `tracerLogger` to eliminate duplicate in-span span-event exports, and applies dedicated flusher/serialization layers. Desktop exports main process traces and logs over OTLP while withholding metric emissions until metrics are instrumented. OTLP settings and HTTP header sets are isolated per signal (traces, metrics, logs) across server and desktop configurations. Adversarial review findings resolved: preserved `pylon-server` runtime and service identity defaults, verified `DEFAULT_SIGNAL_EXPORT` fallback, tested backward compatibility of `ServerObservability` schema decoding, and validated log deduplication. Cursor unchanged. | Cycle [#689](https://github.com/pylon-code/pylon/issues/689), [PR #690](https://github.com/pylon-code/pylon/pull/690); independent adversarial review, new ServerLogger test suite, 9 desktop observability tests, all CI checks green. |
| Web chat/diff polish, editor discovery, diff cache eviction, ACP elicitation, and preview recovery / `c14f6015bfe479d313355cb234af1a5c16dbb15f` | `c14f6015bfe479d313355cb234af1a5c16dbb15f` (#12453), `0ff87f251db0f19c961e6878b4d82f7e77402a58` (#10831), `4a560b4e4e83c076595ee5d92df2778c187be099` (#12438), `9accc567675f0a0d0a7a37171d9d9ae5a5ec1279` (#12571), `dfbb11bdd7be977caee6dfa12d8a0c4f82862d64` (#12377), `408ff8ae9b1ecaebe1b6c00d603a1100f7eb6ea4` (#12439), `cb3d95c174ee0f9d984cfb7ff0352ad58b18ca78` (#12523), `de6a230db00bc1da1ffceaa6d10fa096df615f3e` (#11294), `efb96939fb39908ea0e80ce5662bb1e3704257ca` (#7861), `5378f87f9999a0db83f06b997c674254a6136d85` (#12535) | Adopted all ten across Cycle #685 Group A (PR #686) and Group B (PR #687). Retained whitespace when copying diff contents, kept linebreaks in citation content, opened chat popovers with relative placement, discovered installed external editors on desktop outside PATH, wrapped long titles in confirmation dialogs, showed plain text in collapsed thought previews, released oversized pull request diff cache entries, accepted ACP SDK elicitation requests (`session/elicitation` & `elicitation/create`), surfaced Codex app permission requests as approvable, and recovered preview host registration after request timeouts via connection queue eviction. Hardening and adversarial review findings resolved: normalized `acceptAlways` approval decision in Codex session runtime to grant permissions, enforced retirement epoch and quarantine boundaries on approval requests, scoped event emission with `CodexNotificationEpoch`, wrapped diff cache invalidation in `Effect.uninterruptible`, cleaned up mobile icon maps, and rebranded pre-existing PR tool descriptions to Pylon. Preserved Pylon Effect services, session lifecycles, and UI layout authority. Cursor unchanged. | Cycle [#685](https://github.com/pylon-code/pylon/issues/685), [PR #686](https://github.com/pylon-code/pylon/pull/686) and [PR #687](https://github.com/pylon-code/pylon/pull/687); independent adversarial reviews, 260+ focused unit tests across web, server, and effect-acp, full workspace typecheck, scoped format/lint. |
| Web interaction, ACP session startup stderr, Claude continuation, and GTK4 snapshot / `52d08a14b9cbff859d044238e8ec4e1cb5bf4d50` | `8dd02470b1e7603b8d36a21ae27c510480351f18` (#12552), `7445aa733ada33e45289e5aa5055f79142556513` (#11263), `599c9776eb887d4fff42da7d2daf8aa07ee9a9e2` (#11268), `dcf8942304cfef382af55c0068cb2f04c86757fc` (#12636), `e36725682bd2935f1bcfdf81660cb569b5f3df29` (#12577), `63ff33756c714e8687ea71a3bc8aa4e9303503f1` (#12624), `d6f291303d7c3ebcbfe8eeae5d6666ecbc4d20ae` (#12625), `52d08a14b9cbff859d044238e8ec4e1cb5bf4d50` (#12635) | Adopted all eight across Cycle #682 Group A (PR #683) and Group B (PR #684). Preserved draft question input when clicking options, desktop CSP screenshot annotations, restored providers settings heading, aligned PR detail menu glyphs. Empty Claude homePath correctly resolves and shares continuation with `~/.claude` or `CLAUDE_CONFIG_DIR`, surfaced ACP stderr excerpt in session startup failures instead of generic closed session errors, and extracted desktop accessible text for Flatpak and GTK4 apps in SnapShot. Adversarial review findings resolved: ACP stderr excerpt sanitized against tokens/credentials and pending buffer bounded; defensive empty `homePath` trimming and `CLAUDE_CONFIG_DIR` resolution in OAuth usage; desktop accessibility timeout preserved without premature concurrency overlap. Preserved Pylon provider rate limits and error reporting. Cursor unchanged. | Cycle [#682](https://github.com/pylon-code/pylon/issues/682), [PR #683](https://github.com/pylon-code/pylon/pull/683) and [PR #684](https://github.com/pylon-code/pylon/pull/684); independent adversarial reviews, 225+ focused tests across desktop and server, full workspace typecheck, scoped format/lint. |
| Chat message heading accessibility and compact sidebar density / `b44c1ce5d25ee0d5a5be82e380618a886c19ea96` | `6cdbf76fa4b0509913046abe6105037ded9e52bb` (#11199), `ca2cc1339bbd1904b932c3a92d23a2c0ffe1d267` (#11525), `77bca8b2d76a1f42552e5eee7d277fcb1160347a` (#9417), `df7ccc8fd01f5d2a1d8ec21bef8f9c59398fe913` (#11644), `7b61099886f3aac139ad43fb73873c73ba7baf4f` (#11652), `0118b522955f190e292ba578a509177b9605d392` (#11595) | Adopted all six across Cycle #669 Group A and Group B. Screen readers navigate chat messages as headings with hierarchical levels (`h3` at offset 3); proposed plans expose semantic headings. Compact sidebar rail (`compactSidebarEnabled`) and compact thread row density (`sidebarCompactThreadRows`) added as opt-in settings defaulting to `false`, preserving Pylon's pull request badges and stack integration, custom settings, and avoiding dead delegation UI. Sparse shelves stay pinned to bottom. Adversarial review findings resolved: accessible fallback for `plan-ready` dot in compact rows, drag layout projection fix for compact rail mode, explicit test fixtures. Cursor unchanged. | Cycle [#669](https://github.com/pylon-code/pylon/issues/669), [PR #679](https://github.com/pylon-code/pylon/pull/679) and [PR #680](https://github.com/pylon-code/pylon/pull/680); independent adversarial reviews, 490+ focused tests, `@t3tools/web`, `@t3tools/desktop`, and `@t3tools/contracts` typechecks, scoped lint/format, green CI. |
Expand Down
Loading