fix(mobile): prevent crash on sign out in settings - #40
Merged
Merged
Conversation
(cherry picked from commit 277a7cb4458257e950b7962f67c8fafd8d0e31ab)
Adopts #4899 and answers the question that prompted the review: upstream has no fix for the iOS crash on opening a session, and cannot be its cause either, since Pylon has adopted none of the 99 commits in the range. The cursor deliberately stays at 1add47b32. Only mobile candidates were assessed, so the batch is not complete and reviewed-through must not move.
github-actions
Bot
added
vouch:trusted
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts upstream #4899 (
277a7cb44), a clean single-file cherry-pick.Problem
Signing out from the mobile settings account screen crashed the app.
ConfiguredSettingsAuthRouteScreenrendersUserProfileViewwhileisSignedInis true, so the moment sign-out flips it false the view is torn out from under itself.The fix latches
hasBeenSignedInin a ref and navigates back toSettingsContentwhen a previously signed-in session ends, rather than swapping the subtree mid-unmount.Why now
This screen was unreachable in Pylon until today — mobile never received Pylon Connect's public config, so
hasCloudPublicConfig()was false and every Connect surface, including this one, was omitted. With sign-in working, the crash is newly reachable.Review context
Found during a targeted
review-t3-upstreampass asking whether upstream held a fix or a cause for a separate iOS crash on opening a session. It does not: this is the only mobile crash fix in the 99-commit range, and it touches a different code path.git cherryreports all 99 commits absent from Pylon, so upstream cannot be that crash's cause either.The ledger cursor is deliberately not advanced — only mobile candidates were assessed, so the batch is incomplete and
reviewed-throughstays at1add47b32.Verification
vp run -F @t3tools/mobile typecheck— cleanNot exercised on a device: the separate session-open crash currently prevents a full mobile pass, and this path needs a real sign-out to trigger.
Model: Claude Opus 5. Harness: Claude Code.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.