Repository navigation
Boy scout rule - #198
Closed
tyewang wants to merge 3 commits into
Closed
Boy scout rule#198tyewang wants to merge 3 commits into
tyewang wants to merge 3 commits into
Conversation
Member
|
Thanks, I've been meaning to add linting to the workflow forever, until then this sort of thing is helpful, heh :) |
There was a problem hiding this comment.
- E501 line too long (81 > 79 characters)
Member
|
I added linting to my git hook a while back so most of this should already be fixed, and is probably why the merge conflict exists. Gonna close for now. Thanks again though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is branched from #197, so please take a look at that one first.
This PR just removes some unused imports and makes a conditional more pythonic.