Skip to content

feat: Add authenticate_user method - #191

Closed
ghost wants to merge 5 commits into
pusher:masterfrom
Inthememory:feat/authenticate-user
Closed

ghost wants to merge 5 commits into
pusher:masterfrom
Inthememory:feat/authenticate-user

Conversation

@ghost

@ghost ghost commented Jul 4, 2023

Copy link
Copy Markdown

Description

Issue: #190

Note to reviewers

Reviewing commit by commit might provide a clearer vision than reviewing the end result.

CHANGELOG

  • [CHANGED] Add authenticate_user method on Pusher::Client
  • [CHANGED] Minor refactoring to share some utilities and ensure signature's consistency

@ghost ghost changed the title Feat/authenticate user feat: Add authenticate_user method Jul 4, 2023
@benjamin-tang-pusher benjamin-tang-pusher self-assigned this Aug 24, 2023
@benjamin-tang-pusher

Copy link
Copy Markdown

Thanks for the PR, I will review it.

@benjamin-tang-pusher

This comment was marked as resolved.

@benjamin-tang-pusher

Copy link
Copy Markdown

Added a couple more things: Inthememory#1

@grk

grk commented Jan 7, 2025

Copy link
Copy Markdown

Hey, is there any chance this could get merged?

@Keith-wright

Copy link
Copy Markdown
Contributor

Superseded by #197 which has now been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants