fix(uexecutor): bound remaining uint256 parses; remove MsgMigrateUEA (F-2026-18798) - #362
Merged
Merged
Conversation
…ateUEA gas_limit and gas_fee_used now go through ValidateUint256String. MsgMigrateUEA and MigrationPayload are removed; migration no longer uses them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining unbounded
big.Int.SetStringsites from F-2026-18798.gas_limit/gas_fee_usednow go throughValidateUint256String(length cap before the parse, thenBitLen() <= 256). Thegas_limitsite also never checked the sign — it discarded the parsed value with_— so"-5"was accepted; it isn't now.MsgMigrateUEAandMigrationPayloadare removed rather than patched. Migration no longer goes through this message, andValidateBasicruns before the ante handler, so retiring only the handler would have left the unbounded parse reachable for free.State-machine breaking — needs a chain upgrade. No state migration; messages aren't stored in state.
The
MsgExecutePayloadsigner-binding and signer-length coverage inapp/anteis deliberately intact; only theMsgMigrateUEAcases were removed from those tables.