Conversation
…sion recommendations Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
* Branding Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Allow only squash merging Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Clarify the requirements for merge rules in the README and ensure all general merge types are enabled for rulesets to be honored. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR represents a major refactoring of the ProjectTemplate, reorganizing the solution structure and introducing new functionality while removing AOT (Ahead-of-Time compilation) support.
Changes:
- Introduced a new CodeGen project for automated code generation with API integration capabilities
- Refactored the Library project to use Microsoft.Extensions.Logging instead of Serilog, reducing dependencies
- Simplified the Console project by removing command-line options and processing logic
- Removed AOT compilation support from Docker builds and project configurations
- Updated GitHub Actions workflows with improved naming conventions and new CodeGen automation
- Enhanced README with comprehensive documentation, installation guides, and project setup instructions
- Modified project properties to use conditional AOT verification and removed explicit assembly names
Reviewed changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Tests.csproj | Removed AssemblyName, NeutralLanguage, and Console project reference; added IsPackable and IsTestProject properties |
| Library/Library.csproj | Removed AssemblyName, NeutralLanguage, VerifyReferenceAotCompatibility, and HTTP/Serilog dependencies; added conditional AOT verification and Microsoft.Extensions.Logging |
| Library/Library.cs | Added new TemplateLibrary class with ILogger support |
| Library/Extensions.cs | Changed from Serilog to Microsoft.Extensions.Logging with LoggerMessage source generation; changed visibility to internal |
| Library/GlobalUsings.cs | Replaced Serilog with Microsoft.Extensions.Logging namespaces |
| Console/Console.csproj | Simplified version properties, added conditional AOT verification, replaced Serilog.Sinks.Async with Serilog.Extensions.Logging, removed InternalsVisibleTo |
| Console/Program.cs | Refactored to use primary constructor, removed ParallelOptions and HttpClient fields, simplified execution flow |
| Console/ProcessTask.cs | Deleted file - sample processing logic removed |
| Console/CommandLine.cs | Removed path, dryrun, and threads options; simplified to basic logging configuration |
| Console/LoggerFactory.cs | Added CreateLogger method for Microsoft.Extensions.Logging integration |
| Console/Extensions.cs | Added dual extension methods for both Serilog.ILogger and Microsoft.Extensions.Logging.ILogger |
| Console/.editorconfig | Added CA1515 suppression with TODO comment |
| CodeGen/* | New project for code generation with HTTP client, API integration, and automated PR workflow |
| Benchmarks/Benchmarks.csproj | Removed AssemblyName and documentation file generation properties |
| Docker/Dockerfile | Removed clang and zlib1g-dev AOT dependencies from installation |
| Docker/Build.sh | Removed AOT build targets and related logic |
| README.md | Comprehensive rewrite with detailed installation, configuration, usage, and template setup instructions |
| HISTORY.md | New file for release history |
| ProjectTemplate.slnx | Added CodeGen project, removed Console build dependency, updated workflow file references |
| ProjectTemplate.code-workspace | Added spell check words and markdown TOC settings |
| .vscode/launch.json | Added CodeGen launch configuration, removed command-line arguments from Console |
| .gitignore | Added .DS_Store and *.user exclusions |
| .github/workflows/* | Renamed and reorganized workflows with consistent naming conventions, added CodeGen automation |
| .github/dependabot.yml | Removed develop branch configuration |
Comments suppressed due to low confidence (2)
.github/workflows/build-release-task.yml:74
- The step names "Download library build artifacts job" and "Download executable build artifacts job" incorrectly use "job" suffix when they should use "step" suffix for consistency with other step names in this workflow (e.g., "Checkout code step"). The naming convention for steps should be consistent throughout the workflow.
.github/workflows/build-release-task.yml:77 - The step name "Create GitHub release job" incorrectly uses "job" suffix when it should use "step" suffix for consistency with other step names in this workflow (e.g., "Checkout code step"). The naming convention for steps should be consistent throughout the workflow.
Enhance the README for clearer setup instructions and update branding for consistency. Adjust merge rules and clarify requirements in the documentation. Include additional project files and configurations to support development and code generation tasks. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improve the logging framework with global configuration options and refactor the code structure. Enhance documentation across multiple files and add agent instructions for better clarity. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 62 out of 65 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/build-release-task.yml:76
- Inconsistent naming: Steps should end with "step", not "job". The step names "Download library build artifacts job" and "Download executable build artifacts job" should be "Download library build artifacts step" and "Download executable build artifacts step" respectively. Similarly, "Create GitHub release job" should be "Create GitHub release step".
Improve code structure and documentation across multiple files, enhance the logging framework with global configuration options, and update the testing framework references. Additionally, reorganize the README to clarify branching workflow requirements. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.