Do not use pip-install; add dependency cooldowns - #5146
Conversation
|
Zizmor recommends against |
8a0b468 to
ff03ce8
Compare
|
setup-python 7.0.0 has removed the input: actions/setup-python#1336 Would it be a bad idea to set |
|
A repository-level fix sounds good! |
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
3210e7b to
87a0e55
Compare
Currently setup-python is uninstalling 26.2 and reinstalling 26.1, adding more time to every workflow and an extra line to every workflow file I kept it in places where we use matrix python versions. Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
|
virtualenv 20.39.1 (via hatch) uses pip 26.0: https://github.com/pypa/virtualenv/blob/20.39.1/src/virtualenv/seed/wheels/embed/__init__.py#L39 virtualenv 21.3.0 bumps pip to 26.1: https://github.com/pypa/virtualenv/blob/21.3.0/src/virtualenv/seed/wheels/embed/__init__.py#L42 Working around this by manually calculating PIP_UPLOADED_PRIOR_TO until we can bump virtualenv #5023 (blocked by #5037, which is blocked by pypa/hatch#2257) |
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
And add it to more workflows and the Dockerfile Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
|
It's better to set PIP_UPLOADED_PRIOR_TO inline after all, because otherwise it won't be included in workflows triggered by forks. I also added it to the Dockerfile. |
Zizmor recommends against pip-install (https://docs.zizmor.sh/audits/#misfeature).
Also add dependency cooldowns to prevent supply-chain compromises.