Fix some constness / char literal issues being found by MSVC standard conforming mode - #8344
Conversation
|
@acozzette, I am fine with adjusting the code according to the style guide, but is there any chance that Google, being a visionary sponsor of PSF, could make something to fix this issue right in the Python itself? These const_cast's are nasty. Removing them in the future would require adding |
georgthegreat
changed the title
|
@georgthegreat This would definitely be nice to fix within Python itself, but unfortunately I don't think I can help much there because I'm not really connected to anyone would be in a good position to work on that. |
georgthegreat
left a comment
georgthegreat
left a comment
There was a problem hiding this comment.
Ok. Fixing this in python will require changes in many opensource projects anyway. It's better not to block on this.
I have changed to const_cast, as requested.
| static const char* kwlist[] = {"descriptor_db", 0}; | ||
| PyObject* py_database = NULL; | ||
| if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|O", kwlist, &py_database)) { | ||
| if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|O", (char**)kwlist, &py_database)) { |
There was a problem hiding this comment.
This one is another tricky thing.
CPython C API was using char* for const literals in py2, with many problems being fixed (that is, replaced with const char*) in Python3. This one, however, remains unfixed (this PR attempted to fix it, but did not get to the merge commit and looks abandoned).
Similar crutchy remove_const-casts can be found in various open source projects:
The list includes the following pip packages (but definitely not limited to):
It might be better to fix python problem before merging this PR.
|
@acozzette, none of the above links claiming that Kokoro build failed work for me. Could you, please, help me to understand failure reasons? |
|
Sorry about that, those failures were caused by an unrelated issue that should be fixed now. Let me try running the tests again. |
This is the continuation of protocolbuffers#8344
This is the continuation of #8344
3 participants
This one is somewhat tricky.
According to C Language Standard
"string"has typechar[7](that is, 6 letters + null terminator).According to C++ Standard, however, it has its natural type of
const char[7](see cppreference).An attempt to write
char* ptr = "string";, however, does not cause any errors when compiled by clang or gcc.MSVC has
/permissive-flag which is off by default, unless/std:c++latestis used.This PR fixes issues caused by this type mismatch.