Clear require_password_change after password reset (follow-up to #1494) - #167
Open
aarshe22 wants to merge 1 commit into
Open
Clear require_password_change after password reset (follow-up to #1494)#167aarshe22 wants to merge 1 commit into
aarshe22 wants to merge 1 commit into
Conversation
PR #1494 fixed the 403 on clients-edit.php for forced password changes, but email password reset still left the require_password_change meta set. Clients were then redirected to clients-edit on every login even after resetting via email. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Opened tracking issue for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setNewPassword()), clear therequire_password_changeuser meta so clients are not forced back toclients-edit.phpon every login.legacydevelopasedit_self_account).Fixes #168
Problem
require_password_changemeta remainstrue.password_change_required()still redirects toclients-edit.php?id=<id>.Changes
includes/Classes/PasswordReset.php— delete the meta after a successful reset.includes/Classes/Users.php— also clear it insidesetNewPassword()so all callers that set a password satisfy the requirement.Test plan
require_password_changemeta is removed for that userclients-edit.php)setNewPassword()before saving meta)