This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Repository navigation
Feature: add march hardware interface docs - #131
Merged
Merged
Conversation
Roelemans
suggested changes
Apr 2, 2020
Roelemans
left a comment
Roelemans
left a comment
Contributor
There was a problem hiding this comment.
I think you discussed all important parts 馃憤 few small comments :)
RutgerVanBeek
suggested changes
Apr 2, 2020
RutgerVanBeek
left a comment
RutgerVanBeek
left a comment
Contributor
There was a problem hiding this comment.
I miss some information on the enforcement of the safety limits. Furthermore this tutorials references ros control quite a lot, but how we use ros control is not so well explained anywhere in the tutorials. So we either should make an issue to update that or put some extra information on how we interface with ros contorl here.
RutgerVanBeek
approved these changes
Apr 2, 2020
Roelemans
suggested changes
Apr 2, 2020
Roelemans
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PM-372
Closes #33
Description
Added documentation on march_hardware_interface. Let me know if I missed anything.