Skip to content
This repository was archived by the owner on Dec 1, 2020. It is now read-only.

Fix: high level overview - #128

Merged
Olavhaasie merged 7 commits into
masterfrom
fix/high-level-overview
Mar 31, 2020
Merged

Olavhaasie merged 7 commits into
masterfrom
fix/high-level-overview

Conversation

@Olavhaasie

@Olavhaasie Olavhaasie commented Mar 30, 2020 •

Copy link
Copy Markdown
Contributor

Closes PM-360 and PM-361
Closes #31

Description

The high level overview documentation was outdated, so I updated it. Be sure to check out the new diagram (It's in svg format now).

Changes

  • Update diagram and save in svg format, so it can be edited later and gives better quality
  • Remove reference to old launch menu (PM-360)
  • Add documentation to Input Device section (PM-361)

@Olavhaasie
Olavhaasie requested a review from a team as a code owner March 30, 2020 10:43
@Olavhaasie Olavhaasie self-assigned this Mar 30, 2020

@Joris-JW Joris-JW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general image looks good. However, a small comment. The state machine as well as the gait selection sends a subgait, not really a gait. This could possibly cause confusion. And the font of 'state machine' is different from the rest. Furthermore looks nice!

@Olavhaasie
Olavhaasie requested a review from Joris-JW March 30, 2020 13:27

@Joris-JW Joris-JW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice.

@Ishadijcks Ishadijcks left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you autoformat the svg you might have an easier time checking diffs in the future

@Olavhaasie
Olavhaasie merged commit 95006b7 into master Mar 31, 2020
@Olavhaasie
Olavhaasie deleted the fix/high-level-overview branch March 31, 2020 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Create a high level overview

3 participants