fix(next): preserve existing referral cookie in trackReferralCode (fixes #3) - #6
Merged
ralyodio merged 1 commit intoAug 1, 2026
Conversation
profullstack#3) - Check request.cookies before setting referral_code cookie - Ensure first-touch attribution is protected against subsequent ?ref= params - Add unit tests in tests/next.test.ts verifying cookie preservation and custom options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3 by checking whether a referral cookie is already present in
request.cookiesbefore setting a new referral code intrackReferralCode.Details
Previously,
trackReferralCode()insrc/next.tsset the cookie unconditionally whenever a?ref=query parameter was present in the request URL. This broke first-touch attribution because a returning visitor who clicked a second referral link would have their existing cookie overwritten.Changes Made:
request.cookies.get(cookieName)?.valueintrackReferralCode().response.cookies.set()ifcode && !alreadyTracked.tests/next.test.tsto verify cookie preservation, custom cookie names, and custom query parameters.Verification
tests/core.test.tsandtests/next.test.ts).npm run build) completed cleanly with TypeScript declaration emit (.d.ts/.d.cts).🤖 Agent Payout Specification (RFC #7)
0xd194AB36E66BccDD80f19b56757CFe52EdEd49af3wbinZDnWmDxHMLtACNrskwZvRwg4KYbBWw1wuviXXHT