Skip to content

chore(cli): remove the orm-toolchain engine 0.6.2 conformance exception - #328

Open
wmadden-electric wants to merge 1 commit into
mainfrom
chore/remove-orm-engine-exception
Open

wmadden-electric wants to merge 1 commit into
mainfrom
chore/remove-orm-engine-exception

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

packages/cli/scripts/conformance.ts listed two packages that were allowed to peer an older @prisma/cli-engine than the one prisma ships. This pull request removes the entry for @prisma/orm-toolchain:

       exceptions: [
         {
           familyPackage: "@prisma/composer-cli",
           familyPin: "0.6.1",
           shellPin: "0.6.2",
           ...
         },
-        {
-          familyPackage: "@prisma/orm-toolchain",
-          familyPin: "0.6.1",
-          shellPin: "0.6.2",
-          ...
-        },
       ],

Why now

#313 shipped engine 0.6.2 while both packages still peered 0.6.1, so it added the two entries to let the conformance check pass. @prisma/orm-toolchain 8.0.0-rc.14 now peers engine 0.6.2, and #327 pinned that release. The check no longer finds a mismatch for the ORM, so its entry does nothing. Leaving it would let a real 0.6.1 and 0.6.2 mismatch through if those versions ever met again.

What stays

The @prisma/composer-cli entry stays. The latest Composer release, 0.25.0, still peers engine 0.6.1. That entry goes once Composer releases against 0.6.2 and the CLI pins that release. #314 tracks it and stays open.

Verification

I ran the conformance check locally on both channels, the way .github/workflows/publish.yml runs it.

  • Release channel: 0 failing, 4 allowed. All four allowed findings are for @prisma/composer-cli. None is for the ORM.
  • Development channel (dev version stamped, update-product-versions.mjs --channel dev, lockfile refreshed, rebuilt, PUBLISH_CHANNEL=dev): 5 subject(s) checked, nothing to report.

Refs #314

Agent: pythagoras-29

🤖 Generated with Claude Code

@prisma/orm-toolchain 8.0.0-rc.14 peers @prisma/cli-engine 0.6.2, and the CLI now pins that release, so the check no longer needs to allow the mismatch for it. The composer-cli exception stays until Composer releases against 0.6.2.

Refs #314

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0f1b761b-0c0a-4b5c-9762-7fb044bc503c

📥 Commits

Reviewing files that changed from the base of the PR and between 874b6e6 and 18393db.

📒 Files selected for processing (1)
  • packages/cli/scripts/conformance.ts
💤 Files with no reviewable changes (1)
  • packages/cli/scripts/conformance.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Summary by CodeRabbit

  • Chores
    • Removed the special-case allowance for mismatched toolchain and shell version pins in the tarball conformance check.

Walkthrough

The tarball conformance check no longer includes the exception for @prisma/orm-toolchain pin 0.6.1 with shell pin 0.6.2. The @prisma/composer-cli exception remains.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 18393

This tightens an internal conformance check by removing an exception that is no longer needed. It does not change runtime behavior and has no known merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of the obsolete @prisma/orm-toolchain conformance exception.
Description check ✅ Passed The description directly explains the removed exception, the reason it is obsolete, the retained Composer exception, and the verification results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@328
npx https://pkg.pr.new/@prisma/cli-engine@328

commit: 18393db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant