chore(cli): remove the orm-toolchain engine 0.6.2 conformance exception - #328
wmadden-electric wants to merge 1 commit into
Conversation
@prisma/orm-toolchain 8.0.0-rc.14 peers @prisma/cli-engine 0.6.2, and the CLI now pins that release, so the check no longer needs to allow the mismatch for it. The composer-cli exception stays until Composer releases against 0.6.2. Refs #314 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe tarball conformance check no longer includes the exception for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This tightens an internal conformance check by removing an exception that is no longer needed. It does not change runtime behavior and has no known merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
packages/cli/scripts/conformance.tslisted two packages that were allowed to peer an older@prisma/cli-enginethan the oneprismaships. This pull request removes the entry for@prisma/orm-toolchain:exceptions: [ { familyPackage: "@prisma/composer-cli", familyPin: "0.6.1", shellPin: "0.6.2", ... }, - { - familyPackage: "@prisma/orm-toolchain", - familyPin: "0.6.1", - shellPin: "0.6.2", - ... - }, ],Why now
#313 shipped engine 0.6.2 while both packages still peered 0.6.1, so it added the two entries to let the conformance check pass.
@prisma/orm-toolchain8.0.0-rc.14 now peers engine 0.6.2, and #327 pinned that release. The check no longer finds a mismatch for the ORM, so its entry does nothing. Leaving it would let a real 0.6.1 and 0.6.2 mismatch through if those versions ever met again.What stays
The
@prisma/composer-clientry stays. The latest Composer release, 0.25.0, still peers engine 0.6.1. That entry goes once Composer releases against 0.6.2 and the CLI pins that release. #314 tracks it and stays open.Verification
I ran the conformance check locally on both channels, the way
.github/workflows/publish.ymlruns it.0 failing, 4 allowed. All four allowed findings are for@prisma/composer-cli. None is for the ORM.update-product-versions.mjs --channel dev, lockfile refreshed, rebuilt,PUBLISH_CHANNEL=dev):5 subject(s) checked, nothing to report.Refs #314
Agent: pythagoras-29
🤖 Generated with Claude Code