Skip to content

Add Skip import option to system props rule#21

Merged
colebemis merged 11 commits into
primer:mainfrom
SferaDev:skip-import-system-props
Mar 22, 2023
Merged

Add Skip import option to system props rule#21
colebemis merged 11 commits into
primer:mainfrom
SferaDev:skip-import-system-props

Conversation

@SferaDev

@SferaDev SferaDev commented Nov 25, 2021

Copy link
Copy Markdown
Contributor
  • Add skip import check
  • Auto-fix lint warnings
  • Add exclusions to CircleOcticon and Token

Signed-off-by: Alexis Rico <sferadev@gmail.com>
@changeset-bot

changeset-bot Bot commented Nov 25, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a89654d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread docs/rules/no-system-props.md Outdated

@colebemis colebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SferaDev ❤️

@colebemis

Copy link
Copy Markdown
Contributor

@SferaDev Looks like there are some CI failures. Happy to merge this when those are fixed ✅

Comment thread src/rules/no-system-props.js Outdated
@SferaDev
SferaDev requested a review from colebemis December 8, 2021 21:32
@colebemis
colebemis merged commit 8041452 into primer:main Mar 22, 2023
This was referenced Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants