Skip to content

no-system-props: Add position as allowed prop for Dialog#145

Merged
siddharthkp merged 2 commits into
mainfrom
allow-dialog-position
Mar 5, 2024
Merged

no-system-props: Add position as allowed prop for Dialog#145
siddharthkp merged 2 commits into
mainfrom
allow-dialog-position

Conversation

@siddharthkp

Copy link
Copy Markdown
Member

@siddharthkp
siddharthkp requested review from a team and broccolinisoup March 4, 2024 14:49
@changeset-bot

changeset-bot Bot commented Mar 4, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 68b9edb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Mar 4, 2024
@siddharthkp
siddharthkp requested review from pksjce and removed request for broccolinisoup March 4, 2024 14:49
@siddharthkp siddharthkp changed the title Add position as allowed prop for Dialog no-system-props: Add position as allowed prop for Dialog Mar 4, 2024
@siddharthkp
siddharthkp requested review from joshblack and langermank and removed request for joshblack and langermank March 4, 2024 14:55
@siddharthkp
siddharthkp merged commit 0369cb8 into main Mar 5, 2024
@siddharthkp
siddharthkp deleted the allow-dialog-position branch March 5, 2024 11:26
@primer-css primer-css mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants