Repository navigation
Change Video.PodID to a string, as per the spec - #2
Merged
Merged
Conversation
Contributor
Author
|
@bsardo Can you please take a look at this? |
Contributor
Author
|
Or perhaps @SyntaxNode ? |
Contributor
|
Good catch. Thank you for correcting the mistake. Could you please fix the same in the openrtb2 audio struct? |
Contributor
Author
|
Done. |
SyntaxNode
reviewed
Jan 10, 2023
| // share the same podid, this indicates that those impression opportunities | ||
| // belong to the same video ad pod. | ||
| PodID int64 `json:"podid,omitempty"` | ||
| PodID string `json:"podid,omitempty"` |
Contributor
There was a problem hiding this comment.
The AdCOM PodIDs are integers, per: https://github.com/InteractiveAdvertisingBureau/AdCOM/blob/master/AdCOM%20v1.0%20FINAL.md
Looks like the ad podding changes to AdCOM don't match the changes to OpenRTB 2.6. I don't closely follow AdCOM, but I'll track down what happened. Let's keep the adcom package int64 to match the spec, but openrtb2 should use a string. I think I see where my original gaffe came from. :)
Contributor
Author
There was a problem hiding this comment.
Got it. Reverted that change.
julian-burger-ttd
force-pushed
the
jay-pod-id-string
branch
from
January 10, 2023 17:25
2c61f35 to
702ad16
Compare
SyntaxNode
approved these changes
Jan 17, 2023
bsardo
self-requested a review
January 18, 2023 18:25
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.