AppNexus, Rubicon, and Index Exchange Bid Adapters: add parameter type declarations - #15428
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Some adapters in this PR do not follow Prebid naming conventions. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 978759b242
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Barecheck - Code coverage reportTotal: 96.66%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2244d70620
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…pe declarations (prebid#15428) * Add bidder parameter type declarations * Fix bidder parameter declaration coverage * Complete bidder alias and coordinate types * AppNexus Bid Adapter: prefer underscore parameter names
All three of these adapters are being replaced but are quite popular. Adding the maintainers as reviewers. who will hopefully pr the newer companion module if necessary.
Motivation
paramsshapes in the sharedBidderParamsinterface without changing runtime behavior.