Skip to content

AppNexus, Rubicon, and Index Exchange Bid Adapters: add parameter type declarations - #15428

Merged
patmmccann merged 4 commits into
masterfrom
codex/add-.d.ts-type-files-for-bidders
Aug 26, 2026
Merged

patmmccann merged 4 commits into
masterfrom
codex/add-.d.ts-type-files-for-bidders

Conversation

@patmmccann

@patmmccann patmmccann commented Aug 3, 2026 •

Copy link
Copy Markdown
Collaborator

All three of these adapters are being replaced but are quite popular. Adding the maintainers as reviewers. who will hopefully pr the newer companion module if necessary.

Motivation

  • Provide public TypeScript declarations for common bidder parameters to improve editor completion and type checking for publishers using AppNexus, Rubicon, and Index Exchange.
  • Surface existing adapter params shapes in the shared BidderParams interface without changing runtime behavior.

@github-actions

github-actions Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
patmmccann requested a review from jsnellbaker August 3, 2026 14:28
@patmmccann patmmccann changed the title Bid Adapters: add parameter type declarations AppNexus, Rubicon, and Index Exchange Bid Adapters: add parameter type declarations Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Some adapters in this PR do not follow Prebid naming conventions.
Module appnexusBidAdapter defines bidder alias appnexusAst, which contains uppercase or non-alphanumeric characters

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 978759b242

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/appnexusBidAdapter.d.ts
Comment thread modules/appnexusBidAdapter.d.ts Outdated
Comment thread modules/appnexusBidAdapter.d.ts Outdated
Comment thread modules/rubiconBidAdapter.d.ts Outdated
@barecheck

barecheck Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

@patmmccann

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2244d70620

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/rubiconBidAdapter.d.ts Outdated
Comment thread modules/appnexusBidAdapter.d.ts
Comment thread modules/appnexusBidAdapter.d.ts Outdated
Comment thread modules/appnexusBidAdapter.d.ts Outdated
@patmmccann
patmmccann requested a review from jsnellbaker August 24, 2026 21:16

@jsnellbaker jsnellbaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for appnexus

@patmmccann
patmmccann merged commit 8ec67df into master Aug 26, 2026
129 of 130 checks passed
@patmmccann
patmmccann deleted the codex/add-.d.ts-type-files-for-bidders branch August 26, 2026 08:11
steffenmllr pushed a commit to mllrsohn/Prebid.js that referenced this pull request Sep 28, 2026
…pe declarations (prebid#15428)

* Add bidder parameter type declarations

* Fix bidder parameter declaration coverage

* Complete bidder alias and coordinate types

* AppNexus Bid Adapter: prefer underscore parameter names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants