Skip to content

feat(reusable-workflows)!: input param consistency #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppat merged 1 commit into from
Sep 3, 2026
Merged

feat(reusable-workflows)!: input param consistency #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
required: false
type: boolean
secrets:
client_id:
app_client_id:
required: true
app_private_key:
required: true
Expand All @@ -33,7 +33,7 @@ jobs:
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
id: app-token
with:
client-id: ${{ secrets.client_id }}
client-id: ${{ secrets.app_client_id }}
private-key: ${{ secrets.app_private_key }}
owner: ${{ github.repository_owner }}
repositories: ${{ github.repository }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/renovate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: number
default: 10
secrets:
client_id:
app_client_id:
required: true
app_private_key:
required: true
Expand All @@ -38,7 +38,7 @@ jobs:
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
id: app-token
with:
client-id: ${{ secrets.client_id }}
client-id: ${{ secrets.app_client_id }}
private-key: ${{ secrets.app_private_key }}
owner: ${{ github.repository_owner }}
repositories: ${{ github.repository }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/self-release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ jobs:
release:
uses: ./.github/workflows/release-please.yaml
secrets:
client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_private_key: ${{ secrets.HOMELAB_BOT_APP_PRIVATE_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/self-renovate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
git_ref: ${{ github.head_ref || github.ref }}
log_level: debug
secrets:
client_id: ${{ secrets.RENOVATE_CLIENT_ID }}
app_client_id: ${{ secrets.RENOVATE_CLIENT_ID }}
app_private_key: ${{ secrets.RENOVATE_APP_PRIVATE_KEY }}
dockerhub_username: ${{ secrets.DOCKERHUB_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/self-test-aqua.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ jobs:
semantic_commit_type: test
semantic_commit_scope: internal-workflows
secrets:
client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_private_key: ${{ secrets.HOMELAB_BOT_APP_PRIVATE_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/self-test-release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ jobs:
dry_run: true
verbose: true
secrets:
client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_client_id: ${{ secrets.HOMELAB_BOT_CLIENT_ID }}
app_private_key: ${{ secrets.HOMELAB_BOT_APP_PRIVATE_KEY }}
4 changes: 2 additions & 2 deletions .github/workflows/update-aqua-checksums.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ on:
type: string
default: "dev-tools"
secrets:
client_id:
app_client_id:
required: true
app_private_key:
required: true
Expand All @@ -49,7 +49,7 @@ jobs:
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
id: app-token
with:
client-id: ${{ secrets.client_id }}
client-id: ${{ secrets.app_client_id }}
private-key: ${{ secrets.app_private_key }}
owner: ${{ github.repository_owner }}
repositories: ${{ github.repository }}
Expand Down
Loading