CRITICAL: WAL write failure returns 0 - indistinguishable from success #134

Why is this an issue?

In src/transaction/wal.cpp:81:

if (!wal_file_.is_open()) return 0;

When WAL write fails, returns 0. Callers cannot distinguish from legitimate LSN 0. Transactions proceed without logging.

What is causing it?

Silent failure returns 0.

How can it be solved?

Return error or throw exception.

Category

• Small
• Medium
• Large
• Critical

Severity

• Low
• Medium
• High
• Critical