Move internal domain packages to pkg/ for public import - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the public
pkg/tree by movinginternal/book,internal/catalog, andinternal/webtopkg/book,pkg/catalog, andpkg/web, with repo-wide import rewrites. Phase 1 of the importable-library workstream, followingthe in-place decouple and ahead of the public API polish.
What's new
pkg/book(domain types and pure logic),pkg/catalog(TOML storage, schema migration,SQLite index), and
pkg/web(title fetch, URL open) are importable by external modules.git mvrenames plus 44 one-line import swaps across 18 files; zero logic edits.pkg/package importsbubbletea,huh,lipgloss,urfave, orinternal/*.Behavior changes / guardrails
internal/themeandinternal/modelstay internal;cmdkeeps owning flag layering, spinners, and styled errors.pkg/API follows module semver but may break on minor releases until the tool cuts v2.0.0.Testing
go list -deps ./pkg/...is free of TUI and CLI framework imports.trash, restore, doctor, gc.
make checkruns fmt, vet, lint, and tests; all green.