feat: add DepthPicking component and useDepthPicking hook - #372
Merged
Conversation
Extracted from Autofocus into a standalone, reusable primitive for reading world-space positions off the depth buffer. Also splits DepthPicking and N8AO into a new src/passes directory, since neither wraps a postprocessing Effect.
|
Thanks for this one, great to hear! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288
Summary
<DepthPicking>component anduseDepthPickinghook for reading world-space positions off the depth buffer, extracted from<Autofocus>into a standalone, reusable primitive.<Autofocus>now builds on both internally, same external behavior.useDepthPickingauto-detects the composer's own camera when used inside its<EffectComposer>, with an explicitcameraargument to override when called from outside that tree.DepthPickingandN8AOinto a newsrc/passesdirectory, since neither wraps apostprocessingEffect.Test plan
yarn typecheck/yarn test/yarn eslint:ci/yarn build<Autofocus>(mouse + debug), self-occlusion (depthWrite),enableNormalPass+ surrounding effects, and drei's<PerspectiveCamera>