Skip to content

EffectComposer doesn't work properly inside of drei View component. #285

Description

@closedcontour

EffectComposer.tsx sets the size of the renderer based on the value of size from useThree(). When using the View component from react-three-fiber, that size value doesn't necessarily track the size of the underlying canvas which results in the view being improperly offset.

It's not entirely clear that the fix should be in this library, but it seemed like the cleanest to me.

I'm using this fix: master...closedcontour:react-postprocessing:effect-composer-sizing. I'm happy to open a PR if you'd like. Thanks.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingv3.1

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions