Repository navigation
chore(deps): Introduce webpack-dev-server v5 - #802
DatGreekChick wants to merge 2 commits into
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
| "webpack-dev-server": "^4.2.1", | ||
| "webpack-dev-server": "^5.0.2", | ||
| "webpack-dev-server.4": "npm:webpack-dev-server@4.x", | ||
| "webpack-dev-server.legacy": "npm:webpack-dev-server@3.x", |
There was a problem hiding this comment.
We probably want to rethink this name if we keep v3, v4, and v5
|
@pmmmwh bump! 😄 |
|
I just realized that webpack-dev-server is now in v5 after reading this PR ... and now I'm in the same boat since I accidentally also updated it. |
|
Having the same problem. |
|
I don't recommend doing this for commercial projects, but if you run npm install -D webpack-dev-server@5 --forcethis package might still continue to work. It worked fine on my website, but that's a rather small site (and not one I get paid to develop 😅) so don't take undue risk where unnecessary! (though it should be fine as a dev dependency regardless!) |
|
Thank you - I tried and it works but not all. |
|
Put this in your |
|
@captainamerican Thank you so much! This saves me from using |
|
is there any chance that this will be merged in the near future? or what is the plan to support webpack-5? and when? |
I haven't heard from the author at all, so until then I'd use the overrides. |
|
Thanks for this |
|
CI fail block this PR: |
|
Hey - thanks for the PR and sorry for my silence. Since this change will bump the required Node.js version, we'll likely have to release a new version; I'll get to that this week. On a high level - I think this is also probably the time to drop WDS v3 support. It was last published on 8 May 2020 (roughly 4 years ago); removing that would also allow us to drop some of the legacy code we needed to support that. Maybe even v4 as well - I think we'd be ok on compatibility if there's a |
|
Fixed by #837 - will track work towards |
Motivation
When running
npm outdatedI sawwebpack-dev-serverwas on the list. However, when I attempted to update it to latest, I got an error:Thus, this commit makes a first attempt at introducing
webpack-dev-serverv5.What's Changed
nodeversion to18.12in enum within.circleci/config.ymlwebpack-dev-serveralias for v4package.jsontest/helpers/sandbox/alias4WebpackDevServer.jstest/helpers/sandbox/configs.jswebpack-dev-server@5and includes this new version inpeerDependenciesthis.global.WDS_VERSION(this is certainly wrong at the moment) intest/jest-environment.jstypes, but that likely needs to be ripped away or modified in a different commitTests
I ran
yarn run test:execandyarn test, but I'm seeing local failures connecting to the port among other issues. I suspect because the entire update isn't complete this is why there are failures as the test suite passed fully on main.Notes
I attempted to follow previous commits for updating
webpack-dev-server, but we can consider this commit a WIP until everything passes. I see there was an attempt from @jipis in #801, but I wonder if the default values need WDS@4, so I left much of that intact. I'm happy to work on this with Jonathan and you, Michael @pmmmwh!Also, there's no
CONTRIBUTING.mdfile, which might be helpful in understanding how to correctly set up this repository and make changes to it! I'm happy to help with this as well 🤝RESOLVES #800