Add Black - code formatter for python #14

Activity

1. lukaszstolarczuk

   added

   Type: FeatureNew feature or requestNew feature or request

   on Dec 5, 2019
2. hamzzy commented on Jan 6, 2021

   

   hamzzy

   on Jan 6, 2021

   More actions

   can it be add to github action when ever a push is made
3. lukaszstolarczuk commented on Jan 7, 2021

   

   lukaszstolarczuk

   on Jan 7, 2021

   Member

   More actions

   @hamzzy, we haven't discussed this feature yet, but if you're saying we should automatically format code (and also automatically commit possible changes) on push then we are not fans of such solution.
   We usually just deliver code formatter for us/developers to use, and on CI we only check if code format is proper and fail otherwise - is that good enough for you?
4. hamzzy commented on Jan 7, 2021

   

   hamzzy

   on Jan 7, 2021

   More actions

   okay cool.
5. hamzzy commented on Jan 7, 2021

   

   hamzzy

   on Jan 7, 2021

   More actions

   Also, the python wrapper isn't documented.
   I don't know if such is a need.

   I would love to contribute to such.
6. lukaszstolarczuk commented on Jan 7, 2021

   

   lukaszstolarczuk

   on Jan 7, 2021

   Member

   More actions

   Also, the python wrapper isn't documented.
   I don't know if such is a need.

   I would love to contribute to such.

   We do have a documentation, it's available in the code and generated as html in here:
   https://pmem.io/pmemkv-python/

   but we always appreciate any contributions, either pull requests or issues, so feel free to work with us.