Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Generated [deb] package contains compatibility tests #1056

Open

Description

@lukaszstolarczuk

Environment Information

  • libpmemobj-cpp version(s): current master (e.g. 1.12-42-geca8f5f8)
  • tested on Ubuntu 20.10
  • Cmake flag TESTS_COMPATIBILITY is set

Please provide a reproduction of the bug:

cd build
cmake .. -DTESTS_COMPATIBILITY=ON -DCPACK_GENERATOR="DEB"
make package

How often bug is revealed:

always

Actual behavior:

Generated deb package (and probably rpm as well) contains the compatibility tests' sources and hence the old versions of libpmemobj-cpp

Expected behavior:

We should at least print a warning in CMake (with info is not recommended) or just test compatibility in different way (e.g. like in pmemkv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugSomething isn't workingnewneed to be triaged

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions