Repository navigation
Unpin test requirements - #5019
Merged
Merged
Conversation
marthacryan
force-pushed
the
unpin-requirements
branch
from
February 10, 2025 23:15
6862255 to
c2af57b
Compare
emilykl
reviewed
Feb 11, 2025
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
… unpin-requirements
marthacryan
force-pushed
the
unpin-requirements
branch
from
February 11, 2025 19:42
faa3d7c to
d282c49
Compare
marthacryan
marked this pull request as ready for review
February 11, 2025 21:49
emilykl
reviewed
Feb 13, 2025
LiamConnors
reviewed
Feb 17, 2025
marthacryan
force-pushed
the
unpin-requirements
branch
from
February 18, 2025 21:12
be9ae8f to
2a63724
Compare
Narwhals is already bundled with plotly.py, so users shouldn't have to install it themselves
emilykl
reviewed
Feb 19, 2025
emilykl
reviewed
Feb 26, 2025
emilykl
reviewed
Feb 26, 2025
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
emilykl
reviewed
Mar 6, 2025
emilykl
reviewed
Mar 6, 2025
emilykl
approved these changes
Mar 6, 2025
Contributor
There was a problem hiding this comment.
@marthacryan LGTM once my final comments are addressed! 🚀
This is a huge win for maintainability.
A few big-picture thoughts that could be addressed in another PR:
-
IMO we should bring back the no-numpy job (to prevent
numpydependency from accidentally slipping into core Plotly.py) -
If we're testing
pandas<2with Python 3.9, should we also testpandas<2for other Python versions? Probably worth a discussion.
marthacryan
force-pushed
the
unpin-requirements
branch
from
March 6, 2025 22:52
d9f0a5f to
d3de0b1
Compare
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plotly/tools.py