Repository navigation
Move package metadata into pyproject.toml and all other python code into separate file - #4970
Merged
Merged
Conversation
…nto separate file
marthacryan
marked this pull request as draft
January 14, 2025 23:01
emilykl
reviewed
Jan 15, 2025
marthacryan
marked this pull request as ready for review
January 30, 2025 21:39
marthacryan
commented
Jan 30, 2025
marthacryan
commented
Jan 30, 2025
marthacryan
commented
Jan 30, 2025
| version = "6.0.0" | ||
| dynamic = ["dependencies"] | ||
|
|
||
| # TODO: check that this works |
Contributor
Author
There was a problem hiding this comment.
Check the tar file to see what's included
Contributor
Author
There was a problem hiding this comment.
marthacryan
commented
Jan 30, 2025
marthacryan
commented
Jan 30, 2025
emilykl
reviewed
Feb 4, 2025
emilykl
reviewed
Feb 5, 2025
Contributor
|
@marthacryan I took another look through and this is looking good to me! |
emilykl
reviewed
Feb 5, 2025
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
…use-pyprojecttoml
gvwilson
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4811. Custom commands are deprecated for setup.py files, so this PR moves those out of the setup.py. Using pyproject.toml is "strongly recommended" as well, so this PR also includes moving package metadata into that file.
Also, removes the conda recipe because this broke when we updated to pyproject.toml and through discussing it we decided to stop posting a conda recipe. See #5011
Also, moves the
plotly/testsdirectory to the root and_plotly_utils/testsintotests/test_plotly_utils.