Skip to content

Add a build with no numpy to circleci - #4696

Merged
archmoj merged 5 commits into
plotly:masterfrom
marthacryan:add-circle-no-numpy
Jul 30, 2024
Merged

archmoj merged 5 commits into
plotly:masterfrom
marthacryan:add-circle-no-numpy

Conversation

@marthacryan

@marthacryan marthacryan commented Jul 26, 2024 •

Copy link
Copy Markdown
Contributor

Follow-up to this comment recommending adding a CI job testing that plotly works without numpy installed.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
    - [ ] I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.

    - [ ] For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).

    - [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
    - [ ] For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@archmoj archmoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.
💃

@archmoj

archmoj commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

@marthacryan
Thinking of this again, do we have a test to test that numpy is not installed?

@marthacryan

Copy link
Copy Markdown
Contributor Author

@marthacryan Thinking of this again, do we have a test to test that numpy is not installed?

I didn't add anything like that - what sort of test were you thinking?

@archmoj

archmoj commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

@marthacryan Thinking of this again, do we have a test to test that numpy is not installed?

I didn't add anything like that - what sort of test were you thinking?

Before running the tests I want we make sure it is not installed by other requirements.
Perhaps you could run pip list | grep numpy before tests.

Comment thread .circleci/config.yml Outdated
@archmoj

archmoj commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Excellent. 💃

@archmoj
archmoj merged commit 50e31d3 into plotly:master Jul 30, 2024
@marthacryan
marthacryan deleted the add-circle-no-numpy branch November 8, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants