Repository navigation
Update docs dependencies and Python version - #4596
Conversation
| ie the last level corresponds to the root. | ||
| """ | ||
| df_all_trees = pd.DataFrame(columns=['id', 'parent', 'value', 'color']) | ||
| df_trees = [] |
There was a problem hiding this comment.
I don't understand this change but I'm willing to take it on faith :-)
There was a problem hiding this comment.
@LiamConnors My only suggestion here (and at the other spot) is that the df_trees variable be renamed to clarify that it's a list of dfs rather than a df.
There was a problem hiding this comment.
Yeah, sorry, I should have given more context.
The original example uses df.append, to append each new dataframe in the loop to the first dataframe, but that method was removed.
So here I instead use a list, and add each to a list and use pd.concat on the list instead.
We had to make this update also in the plotly.express library itself at one stage and that's the approach we took: #4190
@emilykl good suggestion. Will update the variable name
pd.concat has existed at least since https://pandas.pydata.org/pandas-docs/version/0.13/generated/pandas.concat.html
| ie the last level corresponds to the root. | ||
| """ | ||
| df_all_trees = pd.DataFrame(columns=['id', 'parent', 'value', 'color']) | ||
| df_trees = [] |
There was a problem hiding this comment.
again, I don't understand this change but am willing to trust you.
| ie the last level corresponds to the root. | ||
| """ | ||
| df_all_trees = pd.DataFrame(columns=['id', 'parent', 'value', 'color']) | ||
| df_trees = [] |
gvwilson
left a comment
gvwilson
left a comment
There was a problem hiding this comment.
There are three places where it appears that a single call to Pandas has been replaced by a loop. I don't have enough context to understand the change but am willing to take it on faith; would be happy to discuss.
|
@LiamConnors Are the Pandas example code changes still backwards-compatible with Pandas 1.x? |
Update docs dependencies and Python version
Update docs dependencies and Python version
3 participants
This PR:
np.intanddf.append. https://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html#removal-of-prior-version-deprecations-changesgeoparsefrom Update Plotly.py version for docs #4594 - no longer required with latest version ofpandasTo close #4491